[MPlayer-dev-eng] [PATCH] movie_aspect switching at runtime

[Aurelien Jacobs]

On Sat, 11 Sep 2004 21:58:41 +0900
Attila Kinali <attila at kinali.ch> wrote:

> On Fri, Sep 03, 2004 at 03:17:30AM +0200, Aurelien Jacobs wrote:
> > On Thu, 2 Sep 2004 15:25:43 +0000
> > Sascha Sommer <saschasommer at freenet.de> wrote:
> > 
> > > On Friday 27 August 2004 11:39, Aurelien Jacobs wrote:
> > > > This patch add a new slave command to change the movie_aspect at
> > > > runtime. Will document it if it's ok.
> > > >
> > +    case MP_CMD_SWITCH_RATIO : {
> > +      if (cmd->nargs == 0)
> > +        movie_aspect = (float) sh_video->disp_w / sh_video->disp_h;
> > +      else
> > +        movie_aspect = cmd->args[0].v.f;
> > +      mpcodecs_config_vo (sh_video, sh_video->disp_w, sh_video->disp_h, 0);
> > +    } break;
> 
> I really doubt that this works w/o negative side effects.
> Changing aspect on runtime requires a reinit of the whole vf/vo chain.

With NO filters, it really works without negative effect !
And it is well tested as it's part of GeeXboX since months and
no one complaind about it.
I don't tell that it will work in any situation, but it is mostly
usefull in simple configurations.

Aurel