[MPlayer-dev-eng] [PATCH] movie_aspect switching at runtime

[Vladimir Mosgalin]

On Sat, 11 Sep 2004, Attila Kinali wrote:

AK>> > On Friday 27 August 2004 11:39, Aurelien Jacobs wrote:
AK>> > > This patch add a new slave command to change the movie_aspect at
AK>> > > runtime. Will document it if it's ok.
AK>> > >
AK>> +    case MP_CMD_SWITCH_RATIO : {
AK>> +      if (cmd->nargs == 0)
AK>> +        movie_aspect = (float) sh_video->disp_w / sh_video->disp_h;
AK>> +      else
AK>> +        movie_aspect = cmd->args[0].v.f;
AK>> +      mpcodecs_config_vo (sh_video, sh_video->disp_w, sh_video->disp_h, 0);
AK>> +    } break;
AK>
AK>I really doubt that this works w/o negative side effects.

Well then, just try! It does. With different filters, and without any
side effects, both in fullscreen and window.

Well.. almost without side effects. Looks like it keeps aspect value
separately for fs & window. I guess it would be easy to fix it, and it
really isn't such a big deal.

AK>Changing aspect on runtime requires a reinit of the whole vf/vo chain.

Some time ago, Arpi said that it is possible and there should be no
problems with it, the only thing missing was some ui. This patch fixes
it.

I know about another side-effect, due to long-standing mplayer bug. When
switching aspect in fullscreen with -vo x11, mplayer switches to window
and refuses to go back to fullscreen. The same can be reproduced by
switching to the next video with fixed-vo activated.

-- 

Vladimir