[MPlayer-dev-eng] [PATCH] (loader/ext.c) VirtualAlloc() SIGSEGV on Linux + other fixes

[D Richard Felker III]

On Fri, Sep 10, 2004 at 04:57:56PM +0000, Roberto Togni wrote:
> On 2004.09.10 16:37, Reimar Döffinger wrote:
> >Hi,
> >>Since noone else commented it so far, i'm going to commit it soon if   
> >>noone speaks up now against it.
> >
> >But please don't just uncomment the printfs but instead convert them  
> >to mp_msg (maybe create a MSGT_LOADER and use MSGL_DBG3?).
> No message from ext.c is printed via mp_msg, probably to keep the  
> differences with the original avifile loader down to a minimum.
> Almost all debug messages are printf, and they are just commented out.  
> There are some dbg_ functions at the beginning of the file, but they're  
> never used.
> 
> And thet's the same in all loader/ files.
> 
> What other devels thinks about it?

if the printf's don't get used then i don't care. but after we finish
this, there should be NO active printf's left anywhere, at least
without -v. why? it should be possible to use -dumpfile /dev/stdout or
mencoder -o /dev/stdout...

> Do we still consider avifile as upstream?

probably not. :)

rich