[MPlayer-dev-eng] [PATCH] (loader/ext.c) VirtualAlloc() SIGSEGV on Linux + other fixes
Roberto Togni
r_togni at tiscali.it
Fri Sep 10 18:57:56 CEST 2004
On 2004.09.10 16:37, Reimar Döffinger wrote:
> Hi,
>> Since noone else commented it so far, i'm going to commit it soon if
>> noone speaks up now against it.
>
> But please don't just uncomment the printfs but instead convert them
> to mp_msg (maybe create a MSGT_LOADER and use MSGL_DBG3?).
No message from ext.c is printed via mp_msg, probably to keep the
differences with the original avifile loader down to a minimum.
Almost all debug messages are printf, and they are just commented out.
There are some dbg_ functions at the beginning of the file, but they're
never used.
And thet's the same in all loader/ files.
What other devels thinks about it?
Do we still consider avifile as upstream?
Does it worth to change those printf (all of them, not just
virtuallalloc) to some mp_msg_(MSGT_LOADER, MP_DBG#,...) or not?
Ciao,
Roberto
More information about the MPlayer-dev-eng
mailing list