[MPlayer-dev-eng] Re: [xine-devel] Re: Likely (minor) bug in Real RTSP/RDT demuxing code

[Diego Biurrun]

Miguel Freitas writes:
> 
> On Tue, 31 Aug 2004 04:19:05 +0200, Diego Biurrun <diego at biurrun.de> wrote:
> > >>I noticed the following line:
> > >>      size=(header[1]<<12)+(header[2]<<8)+(header[3]);
> > >>
> > >>Although I don't know much about Real's protocol, it seems likely that this
> > >>should really be:
> > >>      size=(header[1]<<16)+(header[2]<<8)+(header[3]);
> > >>
> > >>i.e., 16 instead of 12.
> > >>
> > >>This becomes an issue only if the chunk size is >65535, which is probably
> > >>why noone noticed it before.
> > 
> > Hmm, no reaction?  Is this a bug or not?
> 
> Still, i personally agree with Ross. I guess we should apply this.

So are you going to apply it?  You haven't yet.. ;-)

Diego