[MPlayer-dev-eng] [PATCH] forceable software volume control

[D Richard Felker III]

On Fri, Nov 05, 2004 at 06:23:52PM +0200, Oded Shimon wrote:
> On Friday 05 November 2004 18:11, Torinthiel wrote:
> > Have you read it? Or have you read the code and here is wrong?
> > I see the range is 50-200. How is 90 close to 200? If you want it neat
> > the middle of scale, which I find reasonable, then 90 is better then 50,
> > and 100 would be even better. Or the code accepts 50-100, and 200 in
> > manpage patch is a mistake.
> You misunderstood the code.
> That variable sets the maximum possible volume, 1 divided by that number.
> 
> So If the 'softvol-normal' is '10', then you can crank up the volume all the 
> way to 1000%, 10 times louder than the source.
> 
> And if its is '200', the maximum volume is '50%' (actually lower than default: 
> 100%. the maximum volume MPlayer would allow would be lower than the source 
> volume...).
> 
> Setting it to 50, would mean the maximum is 200%, and since the default, 
> source volume is 100%, its sitting right in the middle, and it lets you take 
> it up as much as twice the original volume.
> Get it? :)

This is incredibly stupid and broken. It's only a few dB, hardly
sufficient!
If you're going to work on fixing mplayer volume code, make EVERYTHING
work in dB and make the range essentially unlimited. (e.g. -100 dB to
100 dB or something)

rich