[MPlayer-dev-eng] [PATCH] forceable software volume control

[The Wanderer]

Reimar Döffinger wrote:

> Hi, this patch allows to force the volume to be changed via af_volume
> instead of hardware mixer. This should remove the last reason for
> keeping aop (and I _really_ want that outdated crap out of CVS).

For one thing, this doesn't apply for me (to latest CVS). I don't know
why - the patch doesn't look malformed - but 'patch -p0 <
../soft_vol_ctrl.diff' gives seven "Hunk # of # FAILED in <filename"
messages over four different files.

For another:

> +.B \-softvol-norm <10.0\-200.0>
> +Set volume bar position at which volume will not be changed (in percent)
> +(default: 90).

I don't think it's good to have the default "unchanged" volume be near
the maximum possible. Unless some solid justification for a higher value
can be provided, I would prefer to have this default to 50.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.