[MPlayer-dev-eng] [PATCH] forceable software volume control

[Reimar Döffinger]

Hi,
> >Hi, this patch allows to force the volume to be changed via af_volume
> >instead of hardware mixer. This should remove the last reason for
> >keeping aop (and I _really_ want that outdated crap out of CVS).
> 
> For one thing, this doesn't apply for me (to latest CVS). I don't know
> why - the patch doesn't look malformed - but 'patch -p0 <
> ../soft_vol_ctrl.diff' gives seven "Hunk # of # FAILED in <filename"
> messages over four different files.

Maybe your aren't using a clean CVS copy? It works for me with current
CVS...


> >+.B \-softvol-norm <10.0\-200.0>
> >+Set volume bar position at which volume will not be changed (in percent)
> >+(default: 90).
> 
> I don't think it's good to have the default "unchanged" volume be near
> the maximum possible. Unless some solid justification for a higher value
> can be provided, I would prefer to have this default to 50.

Two points:
1) Consistency
It is more in line with the hardware mixer (a value of 50
would make it behave completely different from hardware mixing)

2) Artifacts
Unless the movie is done very badly, with 50 you will get heavy
artifacts when turning the volume up fully, so when you want to get the
maximum working volume you have to try around a lot...
When it is set to 90, you should be able to set the volume to maximum
without getting problems (I actually thought about making 100 the
default, but it works very nice for me like this).

Anyway, it's just a default... If more people vote for a lower value I
will consider it, but unless you provide "solid justification" I will
take my power as the author to set the default as I like it to be ;-)

Greetings,
Reimar Döffinger