[MPlayer-dev-eng] Re: libfaad2 updates

[adland]

> The following sample has pops at the beginning and in the middle,
> though:
> 
> http://www.mplayerhq.hu/~diego/ct_nero-heaac.mp4

Thanks for this issue report.
I have found that the source of the problem was the change to common.h
on line 367 to allow cygwin compilation. (commented out #include <math.h>).
math.h should be included or you get the pops you mentioned when playing back 
sbr or heaac samples (with either build AFAIK - definitely linux).

math.h is different in cygwin as it defines lrintf if __STRICT_ANSI__
is undefined.
this conflicts with a previous assembly  definition in 
common.h causing build to fail as you reported earlier.

tested revision and build works in linux and pops are gone for this sbr sample.
I cant reboot now could you test build in cygwin
here is my suggested 2.0 patch change version to test

could you help testing cygwin?

thanks

diff -Naur 20/libfaad2/common.h updated/libfaad2/common.h
--- 20/libfaad2/common.h        2004-05-11 01:14:37.000000000 -0400
+++ updated/libfaad2/common.h   2004-05-11 01:18:54.000000000 -0400
@@ -32,6 +32,11 @@
 extern "C" {
 #endif

+/* Allow build on cygwin*/
+#if defined(__CYGWIN__)
+#define __STRICT_ANSI__
+#endif
+
 #define INLINE __inline
 #if defined(_WIN32) && !defined(_WIN32_WCE)
 #define ALIGN __declspec(align(16))
@@ -364,7 +369,7 @@
 #  define __USE_ISOC99   1
 #endif

-    //#include <math.h>
+    #include <math.h>

 #ifdef HAVE_SINF
 #  define sin sinf