[MPlayer-dev-eng] Regression / bogus patch in libmpdemux/tvi_bsdbt848.c

Michael Nottebrock michaelnottebrock at gmx.net
Fri Jun 18 04:48:37 CEST 2004


The patch applied in revision 1.8 is wrong and cannot work. I don't know if 
the committer or the submitter was confused back then, the correct version of 
the patch (submitted by the same person) has been in the FreeBSD ports 
collection as a local patch against 0.92.1 for ages.

Noticed so late because the FreeBSD port has only recently been updated to 
1.0pre4. Fix attached.

-- 
   ,_,   | Michael Nottebrock               | lofi at freebsd.org
 (/^ ^\) | FreeBSD - The Power to Serve     | http://www.freebsd.org
   \u/   | K Desktop Environment on FreeBSD | http://freebsd.kde.org
-------------- next part --------------
Index: libmpdemux/tvi_bsdbt848.c
===================================================================
RCS file: /cvsroot/mplayer/main/libmpdemux/tvi_bsdbt848.c,v
retrieving revision 1.13
diff -u -r1.13 tvi_bsdbt848.c
--- libmpdemux/tvi_bsdbt848.c	6 Apr 2004 12:23:09 -0000	1.13
+++ libmpdemux/tvi_bsdbt848.c	18 Jun 2004 02:28:40 -0000
@@ -366,8 +366,8 @@
             }
 
 #ifdef BT848_SAUDIO
-	if((priv->tunerready == TRUE) &&
-	    ioctl(priv->btfd, BT848_SAUDIO, &tv_param_audio_id) < 0)
+	if(priv->tunerready == TRUE &&
+	    ioctl(priv->tunerfd, BT848_SAUDIO, &tv_param_audio_id) < 0)
 	    {
 	    perror("audioid:ioctl");
 	    }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040618/639eb034/attachment.pgp>


More information about the MPlayer-dev-eng mailing list