[MPlayer-dev-eng] Indentation changes in patches

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Jul 12 13:33:46 CEST 2004


Hi,

>>>PS: i think many old commits didn't get handled so strictly!
>>
>>Well, and you know how some of the code looks like.
> 
> yes, and large parts don't look right because of wrong indentations
> that make it a hassle to read the code.

True. Although you could run indent on it for reading in, and use the 
other version for hacking and after you understood the code.
Or do a pure indentation change once every few years ;-), I could live 
with that, although I'm not sure about others...

> I'm not for changing indentation, i'm for for making a difference
> in identical code with a new meaning attached to it.
> And i'm for not breaking indentation in patches.

If that line was really changed, ok. But please don't change indentation 
for lines that otherwise haven't changed. It makes checking patches a 
big lot more difficult, believe me.
And a new if around the code doesn't change its meaning that much after 
all...

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list