[MPlayer-dev-eng] [PATCH] VCD Playback via libdcio

Diego Biurrun diego at biurrun.de
Fri Dec 17 19:19:05 CET 2004


R. Bernstein writes:
> Diego Biurrun writes:
>  > So how is this supposed to work?  You should also update the
>  > documentation in some form.
> 
> I'm not sure I understand what you are asking. What's in the patch
> works exactly like the existing VCD plugin

OK, let me explain my background.  VCD playback has always been broken
on my machine.  I have an old Plextor SCSI CD-ROM and for some reason
it reads VCDs extreeeeeeeemely slow, audio CPU usage goes up to about
1000% and MPlayer displays one frame a second or so.  In short VCDs
are unusable for me and I am thus interested in alternative ways of
playing them.  It's not a hardware problem, way back when I still had
Windows on my machine I could play VCDs without problems.

So libcdio may be an alternative way of handling VCDs that might
actually work on my box (and might also give us VCD support under
Windows).  From a cursory reading of the code I cannot really tell if
I am using libcdio or MPlayer's native VCD handling when I type
'mplayer vcd://'.

Some more comments on your patch: On line 117 of stream_vcdx.c you
have ;; which fails to compile with gcc 2.95.  You should add doxygen
comments to your file, the new patch policy demands it.  Furthermore,
you have trailing whitespace here and there, it's nicer without.

Diego




More information about the MPlayer-dev-eng mailing list