[MPlayer-dev-eng] [PATCH] improved AIFF PCM Audio support - take 4

[Jake Luck]

> > @@ -167,6 +169,10 @@ int demux_audio_open(demuxer_t* demuxer)
> >        frmt = fLaC;
> >        stream_skip(s,-4);
> >        break;
> > +    } else if( hdr[0] == 'F' && hdr[1] == 'O' && hdr[2] == 'R' && hdr[3] == 'M' ) {
> > +      frmt = AIFF;
> > +      stream_skip(s,-4);
> > +      break;
> 
> I didn't read the patch closely, but is it possible to avoid that
> backwards-seek? If yes, please do so, because then e.g. playing from
> stdin will work (even without -cache).
> 
> Greetings,
> Reimar Döffinger

Reimar, thank you for reviewing the patch. 

I used stream_skip(s, -4) to follow the same mental model suggested by the
existing processing code in demux_audio.c. Currently, WAVE, FLAC and MP3
all perform backseek to reset the stream and then carry out a full header
parse. One advantage from this approach is that one no longer needs to
maintain a separate partial header parser.

I feel that if we do choose to eliminate backward-seek we should consider
doing it globally across all codecs to ensure consistency in both code
organization and user behavior.

What do you think?

jake