[MPlayer-dev-eng] [PATCH] improved AIFF PCM Audio support - take 4

Reimar =?UTF8?Q?D=F6ffinger?= Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Dec 9 14:18:03 CET 2004


Hi,
> > > > Can you please retest this with current cvs? I commited a fix for the 
> > > > bigendian sound problem on windows.
> > > 
> > > Thank you, Sasha. Just tested and it works now! Since everyone I have
> > > spoken to is in favor of not creating the extra audio decoder just for
> > > AIFF. I will make the necessary change to ad_pcm and use solution 2.
> > > A revised patch is on the way.
> > 
> > Sasha, here is the new patch that uses ad_pcm.c to perform the decode.  
> > It is diffed from the CVS tree a few minutes ago and has been tested on
> > Cygwin 1.5.12(0.116/4/2) and Mac OS X 10.3.6. 
> 
> Trigger happy and attached the wrong file. Here is the right one.
> Please review and accept. Thank you.
> 
> @@ -167,6 +169,10 @@ int demux_audio_open(demuxer_t* demuxer)
>        frmt = fLaC;
>        stream_skip(s,-4);
>        break;
> +    } else if( hdr[0] == 'F' && hdr[1] == 'O' && hdr[2] == 'R' && hdr[3] == 'M' ) {
> +      frmt = AIFF;
> +      stream_skip(s,-4);
> +      break;

I didn't read the patch closely, but is it possible to avoid that backwards-seek? If yes, please do so, because then e.g. playing from stdin will work
(even without -cache).

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list