[MPlayer-dev-eng] [PATCH] JPEG video output to multiple subdirectories v8

[Attila Kinali]

On Thu, Aug 19, 2004 at 03:37:34AM +0200, Ivo wrote:
> On Monday 16 August 2004 15:42, Attila Kinali wrote:
> > The patch seems to look ok (at least to my sleepy eyes).
> > If the manpage/mp-help part is ok (Diego ?) then it can be applied
> > with one little change: the snprintf at the end shouldnt use
> > ++framecounter, but instead increase framecounter before calling it.
> > (i know it's correct, but using functions with side effects in calls to
> > other functions is a bad coding style IMHO)
> 
> I updated the patch (which is attached) and also...

Ok, this patch can be applied.

> > Ivo: Would you like to take over the maintenance of vo jpeg ?
> > It could need a maintainer.
> 
> ...added myself to the maintainer file. I'd be happy to be the maintainer 
> from now on. When this patch is committed, I would like to do the 
> following:

Please send a mail to Arpi with your desired login.
Please also read DOCS/tech/cvs-howto.txt.

> * Clean up the source by changing the indentation. The one-space indentation 
> it has now (and which I respected in my patch) is horrible. Beyond a depth 
> of three it is unreadable. I believe it's common practice to have one patch 
> that does not change any of the code, but only fixes cosmetics. Is that 
> right? Also, what's the preferred indentation for the mplayer sourcecode?

Yes, you may change indentation, but only once in a while and only
on the code you maintain. Doing so on other peoples code or doing
it too often will lead to removal of cvs write access.

> * After that, I want vo_jpeg to use the -vo jpeg:options style of passing 
> options. Eventualy, the -jpeg commandline option should be removed. What's 
> the rule on removing commandline options? Keep it for a few months (mention 
> it's deprecated in the manual page) and then remove? Or never remove it for 
> backwards-compatability's sake?

There is a "output text when this option is used". eg have a look
at the -dvd and -vcd options.

> * Then I might pick up another multiple file output driver and add the same 
> functionality (spread files over multiple directories, implement -vo 
> driver:options, et cetera). Or maybe all multiple file output drivers 
> should be replaced by one meta-driver called vo_mf (analog to mf:// for 
> input). Like: -vo mf:type=jpeg:further_options. What do you think?

Dunno.. I dont know how much of the code can be shared.
If it's more than just a few lines and if it doesnt overcomplicate
things, why not.


			Attila Kinali