[MPlayer-dev-eng] [PATCH] JPEG video output to multiple subdirectories v8

[Ivo]

On Monday 16 August 2004 15:42, Attila Kinali wrote:
> The patch seems to look ok (at least to my sleepy eyes).
> If the manpage/mp-help part is ok (Diego ?) then it can be applied
> with one little change: the snprintf at the end shouldnt use
> ++framecounter, but instead increase framecounter before calling it.
> (i know it's correct, but using functions with side effects in calls to
> other functions is a bad coding style IMHO)

I updated the patch (which is attached) and also...

> Ivo: Would you like to take over the maintenance of vo jpeg ?
> It could need a maintainer.

...added myself to the maintainer file. I'd be happy to be the maintainer 
from now on. When this patch is committed, I would like to do the 
following:

* Clean up the source by changing the indentation. The one-space indentation 
it has now (and which I respected in my patch) is horrible. Beyond a depth 
of three it is unreadable. I believe it's common practice to have one patch 
that does not change any of the code, but only fixes cosmetics. Is that 
right? Also, what's the preferred indentation for the mplayer sourcecode?

* After that, I want vo_jpeg to use the -vo jpeg:options style of passing 
options. Eventualy, the -jpeg commandline option should be removed. What's 
the rule on removing commandline options? Keep it for a few months (mention 
it's deprecated in the manual page) and then remove? Or never remove it for 
backwards-compatability's sake?

* Then I might pick up another multiple file output driver and add the same 
functionality (spread files over multiple directories, implement -vo 
driver:options, et cetera). Or maybe all multiple file output drivers 
should be replaced by one meta-driver called vo_mf (analog to mf:// for 
input). Like: -vo mf:type=jpeg:further_options. What do you think?

--Ivo van Poorten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_jpeg_patch_v8
Type: text/x-diff
Size: 9978 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040819/5c988eb9/attachment.diff>