[MPlayer-dev-eng] [PATCH] tivo vstream with DOCS

[Torinthiel]

On Thu, Aug 19, 2004 at 07:57:15PM -0500, Joey Parrish wrote:
> Are there any other suggestions or comments?  May I commit this soon?

Now only three from me.
I'm not sure if the test if vstream/Makefile exists is a good test for
building with/without vstream. Ok, I know I shouted on v1 that there was
no test at all, but that was because I'm not sure (I don't want to dig
into the code) if it will build regardless of anything. If yes, then no
test is perfectly fine.

Other thing is that you've now stripped TOO MUCH from vstream/Makefile.
depend does nothing. And it should include top-level config.mak, at
least to select correct optimization.

Also, the file vstream/proto.h states it's autogenerated when you type
"make proto". I remember that there was an awk file not linked to any
usage which probably was for this. I wonder (I'm not sure which is
easier/better) if it's better to include the file, or to enhance
Makefile and add *.awk to generate the file automagically.
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)megapolis(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040820/45495c59/attachment.pgp>