[MPlayer-dev-eng] [PATCH] JPEG video output to multiple subdirectories v5

[Diego Biurrun]

Ivo writes:
> It always feels funny, replying to your own e-mail :) Anyway:

:)

> There where no old messages I could reuse. I also noticed that no other VO 
> driver makes good use of help_mp yet. I took the liberty to create a 
> separate section for Video Output Drivers messages (MSGTR_VO_*). Since 
> nobody uses it yet, I don't think it needs a separate patch, although I 
> kept moving around and renaming other MSGTR messages to a minimum. Didn't 
> rename (because other, non vo_jpeg related files would be effected) and 
> moved only one (out of two candidates) messages to that section.

Good idea.

> On a sidenote: IMHO all printf's in all other VO drivers should be replaced 
> by mp_msg calls with appropriate MSGTR_VO_* definitions. That's beyond the 
> scope of this patch, but if I can be sure I got the hang of this codebase 
> by now (sort-of), I'll be happy to do that.

You are most welcome to do this, it is needed.  Just coordinate your
work with the Wanderer, who is undertaking a similar project.  Maybe
you can do the libvo/ directory.

> Also, I think all VO drivers 
> should honour the "-vo driver:options" way of passing options, instead of 
> having separate commandline switches like -jpeg, -adapter, -dfbopts, -zr* 
> et cetera. Let me know what you think. I could get working on that after 
> this.

This is another cleanup that would be most welcome.  Go ahead and
tackle it, please.  -aa*, -dxr2, -fb, -fbmode, -z are further
candidates.

> Updated manpage with new default value(s) too. Patch is against current CVS.

I'm (again) being nitpickish today, some comments below.

> @@ -1911,17 +1911,27 @@
>  .IPs optimize=<value>
> -Optimization factor [0\-100]
> +Optimization factor [0\-100] (default: 100).

I would write

.IPs optimize=<0\-100>
optimization factor (default: 100)

Writing the range in this way is a bit more consistent with the rest
of the manual page.  Since it is not a complete sentence, you should
not capitalize it and not put a period at the end.

same below

Diego