[MPlayer-dev-eng] [PATCH] JPEG video output to multiple subdirectories v5

[The Wanderer]

Ivo wrote:

> On a sidenote: IMHO all printf's in all other VO drivers should be
> replaced by mp_msg calls with appropriate MSGTR_VO_* definitions.

Actually, all printf calls anywhere in the source should be replaced by
appropriate mp_msg calls. I'm not sufficiently familiar with the various
parts of the code to know what MSGLs and MSGTs to use, but I'm allegedly
going through and replacing each printf("foo") with an
mp_msg(MSGT_FIXME, MSGL_FIXME, MSGTR_FOO) - and of course defining
MSGTR_FOO in the process.

> That's beyond the scope of this patch, but if I can be sure I got the
> hang of this codebase by now (sort-of), I'll be happy to do that.

For the moment, assuming my patches do get dealt with this time around,
it would probably be duplication of effort; however, if you think you
know enough to correctly replace the FIXMEs, I'm sure that would be
welcome after the initial changes have been made.

(For that matter, it might not hurt for you to do the work you suggested
anyway; it would just cut down on what was there for me to do, which I
don't necessarily mind.)

-- 
       The Wanderer, feeling hes overstepping himself

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.