[MPlayer-dev-eng] [PATCH] fixing rgb24toyv12

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Aug 10 21:41:52 CEST 2004


Hi,

>>>the height-2 -> height (and related) change is wrong, it will segfault if
>>>the width has the wrong value
>>
>>no, because I do
>>width &= ~1;
>>height &= ~1;
> 
> no, thats not enough, it will still segfault

Call me stupid but I can't see why. Can you give me a hint? At least it 
worked in my tests ;-)
Anyway, do you agree that the old version could segfault when width / 
height is not divisible by 2, and thus the two line above make sense 
(although they're ugly)?

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list