[MPlayer-dev-eng] [PATCH] fixing rgb24toyv12

[Michael Niedermayer]

Hi

On Tuesday 10 August 2004 21:41, Reimar Döffinger wrote:
> Hi,
>
> >>>the height-2 -> height (and related) change is wrong, it will segfault
> >>> if the width has the wrong value
> >>
> >>no, because I do
> >>width &= ~1;
> >>height &= ~1;
> >
> > no, thats not enough, it will still segfault
>
> Call me stupid but I can't see why. Can you give me a hint? At least it
> worked in my tests ;-)
the mmx code works with more then 2 pixels at a time, so it will write over 
the end, thats why the last line(s) are done with the c code even if width%
2==0

> Anyway, do you agree that the old version could segfault when width /
> height is not divisible by 2, and thus the two line above make sense
> (although they're ugly)?
yes, but i am not happy about the width/height hack

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en