[MPlayer-dev-eng] [PATCH] Depend on bio2jack version 0.2

[ismail dönmez]

Your humble awk-lovin' servant proposes attached patches

Cheers,
ismail

On Tue, 10 Aug 2004 19:16:42 +0200, Diego Biurrun <diego at biurrun.de> wrote:
> ismail dönmez writes:
> >
> > Lastly two patches attached one makes configure to check bio2jack
> > version , the latter makes ao_jack to compile with bio2jack v0.2 .
> 
> Patch rejected.
> 
> Some remarks:
> 
> -int  JACK_SetVolume(int deviceID, int left, int right); /* returns 0 on success */
> +int  JACK_SetVolumeForChannel(int deviceID, unsigned int channel, unsigned int volume);
> 
> Was that comment removed for a reason?
> 
> +        if ( ( test `bio2jack-config --version | awk -F"." '{print $2}'` != 2 ) ) ; then
> 
> There is no need to use full awk here, cut will do the job nicely, or
> - even better - you could simply check for the complete version number
> (0.2) and save yourself calling awk/cut.
> 
> Diego
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 


-- 
Time is what you make of it
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bio2jack_aojack.patch
Type: application/octet-stream
Size: 2071 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040810/7f526024/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bio2jack_configure.patch
Type: application/octet-stream
Size: 618 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040810/7f526024/attachment-0001.obj>