[MPlayer-dev-eng] [PATCH] Depend on bio2jack version 0.2

Diego Biurrun diego at biurrun.de
Tue Aug 10 19:16:42 CEST 2004


ismail dönmez writes:
> 
> Lastly two patches attached one makes configure to check bio2jack
> version , the latter makes ao_jack to compile with bio2jack v0.2 .

Patch rejected.

Some remarks:

-int  JACK_SetVolume(int deviceID, int left, int right); /* returns 0 on success */
+int  JACK_SetVolumeForChannel(int deviceID, unsigned int channel, unsigned int volume);

Was that comment removed for a reason?

+        if ( ( test `bio2jack-config --version | awk -F"." '{print $2}'` != 2 ) ) ; then

There is no need to use full awk here, cut will do the job nicely, or
- even better - you could simply check for the complete version number
(0.2) and save yourself calling awk/cut.

Diego




More information about the MPlayer-dev-eng mailing list