[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

Alex Beregszaszi alex at fsn.hu
Tue Oct 28 19:18:11 CET 2003


Hi,

> video eq can be implemented at many places:
> - codec (see divx4linux, maybe xvid too)
> - yuv<->rgb conversion code (vf_scale)
> - eq filters (vf_eq, vf_eq2, vf_hue)
> - vo driver (think sdl, directfb)
> - hardware (think xv, vidix, mga_vid, xgamma)
Imho we should pick up some of them and not support the others, as it
makes things overcompilcated.

1, hardware support should be present
2, codec support is intresting if it can adjust the values during
decoding and not after it
3, we should redesign the swscale api as discussed, so we could merge
the codebase of eq filters and swscaler
 
> video eq can be controlled at many ways:
> - codec/filter/vo parameters
> - -brightness -contrast etc options
AFAIR these cmdline options call the control().
At least I changed it to that way when I 'cleaned' up Nick's vidix
equalizer mess.

> - VFCTRL_SET_EQUALIZER control() call (used for 1..8 keys for runtime
> control)

-- 
Alex Beregszaszi <alex at fsn.hu>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)



More information about the MPlayer-dev-eng mailing list