[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

[Diego Biurrun]

Arpi writes:
 > >  > >  > anyway since a while the vf_scale filter can do bri/contrast
 > >  > >  > changes too so 'eq' is getting outdated/redundant.
 > >  > >
 > >  > > How can vf_scale do b/c changes?  It's not documented..
 > >  > vf_scale will trap VFCTRL_SET_EQUALIZER, and adjust the b/c/s accordingly if 
 > >  > it can, allthough its only possible ATM if YUV->RGB is done, we surely could 
 > >  > also run some eq like filter in the scaler if YUV->RGB is not done but that 
 > >  > wouldnt be any faster then using the eq filter directly ...
 > > 
 > > Can you dumb this down a bit ;-)
 > > 
 > > Do you mean it reacts to the -brightness and -contrast options?  How
 > > else can you set bri/con if not like this or through a filter?
 > 
 > video eq can be implemented at many places:
 > - codec (see divx4linux, maybe xvid too)
 > - yuv<->rgb conversion code (vf_scale)
 > - eq filters (vf_eq, vf_eq2, vf_hue)
 > - vo driver (think sdl, directfb)
 > - hardware (think xv, vidix, mga_vid, xgamma)
 > 
 > video eq can be controlled at many ways:
 > - codec/filter/vo parameters
 > - -brightness -contrast etc options
 > - VFCTRL_SET_EQUALIZER control() call (used for 1..8 keys for runtime control)

Thanks for the explanation.

Diego