[MPlayer-dev-eng] [PATCH] use mmap() to simplify menu.conf parsing

Joey Parrish joey at nicewarrior.org
Sun Mar 9 08:57:03 CET 2003


On Sun, Mar 09, 2003 at 01:08:34AM -0500, D Richard Felker III wrote:
> On Sat, Mar 08, 2003 at 08:43:09PM +0000, Jason Lunz wrote:
> > libmenu/menu.c copies all of menu.conf into a malloc() buffer for
> > parsing. It's simpler to just mmap() the file.
> 
> This is dumb. Not all operating systems (or file systems) support
> mmap. You could ifdef the code, but that's even stupider since the
> whole point of this patch is to simplify.

Yes, on windows systems, i've had trouble porting code
that relied on mmap.  I agree, the current way is fine.

--Joey


More information about the MPlayer-dev-eng mailing list