[MPlayer-dev-eng] [PATCH] use mmap() to simplify menu.conf parsing

D Richard Felker III dalias at aerifal.cx
Sun Mar 9 07:08:34 CET 2003


On Sat, Mar 08, 2003 at 08:43:09PM +0000, Jason Lunz wrote:
> libmenu/menu.c copies all of menu.conf into a malloc() buffer for
> parsing. It's simpler to just mmap() the file.

This is dumb. Not all operating systems (or file systems) support
mmap. You could ifdef the code, but that's even stupider since the
whole point of this patch is to simplify.

Rich



More information about the MPlayer-dev-eng mailing list