[MPlayer-dev-eng] [PATCH] remove outdated openbox workaround

D Richard Felker III dalias at aerifal.cx
Tue Jun 3 21:07:52 CEST 2003


I received this patch from Mikachu removing a bug workaround for
openbox window manager. Supposedly the relevant bug in openbox was
fixed a long time ago, and IIRC the workaround is now causing the
panel or whatever to appear over top of mplayer's window... Someone
familiar with the x11/wm related code wanna check and see if it's ok?

Rich

-------------- next part --------------
Index: libvo/x11_common.c
===================================================================
RCS file: /cvsroot/mplayer/main/libvo/x11_common.c,v
retrieving revision 1.145
diff -u -r1.145 x11_common.c
--- libvo/x11_common.c  30 May 2003 18:05:49 -0000      1.145
+++ libvo/x11_common.c  3 Jun 2003 02:30:31 -0000
@@ -225,17 +225,6 @@
    for (i = 0; i < nitems; i++)
      wm |= net_wm_support_state_test (args[i]);
    XFree( args );
-   // ugly hack for broken OpenBox _NET_WM_STATE_FULLSCREEN support
-   // (in their implementation it only changes internal state of window, nothing more!!!)
-   if (wm & vo_wm_FULLSCREEN)
-   {
-      if (x11_get_property(XA_BLACKBOX_PID, &args, &nitems))
-       {
-           mp_msg( MSGT_VO,MSGL_V,"[x11] Detected wm is a broken OpenBox.\n" );
-           wm ^= vo_wm_FULLSCREEN;
-       }
-      XFree (args);
-   }
   }
 
  if ( wm == 0 ) mp_msg( MSGT_VO,MSGL_V,"[x11] Unknown wm type...\n" );



More information about the MPlayer-dev-eng mailing list