[MPlayer-dev-eng] [BUG] sig11 if no font (bitmap/ttf) specified!

[Arpi]

Hi,

> This is a very 1000l bug.. Just rm -f ~/.mplayer/font ~/.mplayer/subfont.ttf
> and use the -sub option with a subtitle.. MPlayer throws sig11 at the first
> sub.
> 
> (Interestingly, I still have OSD even after I removed all my fonts. Why?? And
> why doesn't it work? And where does it load it in the following output?)
hmm, it doesn't work for me. are you sure you removed all?

> 432	    if(suboverlap_enabled) obj->y -= vo_font->pic_a[vo_fo
> nt->font[40]]->h - vo_font->height;
> (gdb) bt
> #0  0x080a7a76 in vo_update_osd (dxs=640, dys=272) at sub.c:432
> #1  0x080a880d in vo_draw_text (dxs=640, dys=272, 
>     draw_alpha=0x8097070 <draw_alpha>) at sub.c:642

great... the great sub overlapping code.
-nooverlapsub "fixes" it. so i'll disable overlapping by default for rc3.

this code is very buggy anyway:
  obj->y -= vo_font->pic_a[vo_font->font[40]]->h - vo_font->height;

it should check the validity of vo_font->font[40] (may be 0/-1 if no charcod
40 exists in that font or no font loaded) and also vo_font->pic_a[x] since
it may be null for various reasons.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu