[MPlayer-dev-eng] parser-mpcmd.c - couple of -loop bugs, one fixed

[Arpi]

Hi,

> Noticed a few bugs with the -loop option...
> One is on line 219  if(!end) should be if(*end) ...
> I'll make a patch if you like, but its only one
> character difference!

which file, version?

> Secondly, if -loop is passed as a first arg, eg:
>   $ mplayer -loop 1 foo.avi
> 
> it will play it once, but if its passed after the
> file, eg:
> 
>   $ mplayer foo.avi -loop 1
> 
> it plays it twice. Was gonna try and fix it, but -loop
> seems to parsed it different places depending on where
> it is on the cmdline, and I haven't figured it out
> yet.

yep. the options before the first filename are global opts,
and are parsed (and -loop executed) by the playtree code.
the options after filenames are per-file options, -loop there
is processed by mplayer.c (by seeking back to pos 0).

you can notice that mplayer -loop 0 file will flicker (re-init
videoout, audioout etc after each loop) while mplayer file -loop 0 won't

the first case loops the playlist, the later the single file


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu