[MPlayer-dev-eng] Re: [patch] improve dxr3 tv norm switching

[Thomas Jarosch]

> > Well, they check for em8300 features (don't know what's in 0.12.0),
> > but I just copied them above/below other code I've seen in the module.
> > I'd like to see most of the #ifdefs removed if you agree.
>
> I have removed the unnecessary ones in cvs.

Looks good.

We could furthermore remove

#ifdef MVCOMMAND_SYNC
#ifdef EM8300_IOCTL_FLUSH

as they are already in em8300 0.12.0 (just checked)

> > Because there is way more output without a "." than with a ".".
> > Though we could fix it the other way around,
> > I just wanted to have the same output style.
>
> Hmm, ok... most if not all of those lines were written by Pontscho
> and not me.

So, what is the right course of action? I'd say capitalized letters and ".".
And maybe replace perror() with printf()...

> > > Why did you remove the initialization values to some of the declared
> > > variables? I personally don't like having uninitialized variables
> > > floating around.
> >
> > Jens Axboe did this one, but I don't know why he shouldn't as these
> > are just variables for temporary storage.
>
> Because the change does not do anything useful so I don't see the point in
> it.

Maybe smaller code size? :o) Just kidding...

> > btw: Is "prev_pts" really needed?
> >      I just saw it used in one line.
>
> It's used in a newer version of the code I have lying around.

ok

Thomas