[MPlayer-dev-eng] [PATCH]:targa output with snapshot and index files

[Arpi]

Hi,

> This is my first attept on writing something more complicated that 
> printf("Hello world\n"); in linux and I make also a mistake (at the end, when 
> i fill my hard disk of targa images and check the correct write of the file 
> (whithout check the program!!)
> 
> The patch correct the problem.(I invert count and size of the fwrite(...) 
> call.)
> 
> Doing the tiling as a filter has the advantage that you can output in the 
> format you like (jpeg, png) but it changes fps: is possible to do this 
> without problems?

If you don't play sound (usually you don't when converting to files) then
it's ok.

Also you could left out the scaling, use -vf scale=x:y (with quarter size if
want that) instead.

> I will take a look at the OSD code (all the thing in the module was done to 
> avoid external dipendence or to check the size of the text at runtime, 
> changing the delta between the images).

why do you need text rendering at all?

> BTW in the tga_uty.c code there is a ultra-bad yuv2brg code, i take a look at 
> the rgb2rgb converter but it seem to generate an error if i want to use 
> yuv2rgb(...).

argh!
why do you put conversion to a vo filter? it's done automatically outside
(in vf layer), just tell it what format you prefer (in query_format).


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu