[MPlayer-dev-eng] [PATCH] Possible SDL aspect bug, quick workaround

[Felix Buenemann]

On Sunday 22 June 2003 20:17, Diego Biurrun wrote:
> Alex Beregszaszi schrieb:
> >>>I've been experiencing some wierd behaviour when using -vo sdl:dga
> >>>and today I finally spent some time to track down the problem.
> >>>
> >>>I'm not sure wheter this is an actual bug in MPlayer, or if I just
> >>>don't understand how MPlayer is supposed to work well enough.
> >>>However, this causes a lot (maybe most) of my files to be scaled
> >>>when played in fullscreen mode (sdl:dga), which is a big performance
> >>>penalty on the system I'm using.
> >>
> >>What happend to that patch ?
> >>It's still not applied neither is Alex alternative version.
> >
> > I'm not an SDL specialist..someone familiar should have a look at it.
>
> Atmos?
the aspect code works as expected, as Fredrik is using a resolution of 720x480 
which gives an aspect of 1.5 but he is using a CRT (I presume), which has an 
aspect of 4:3 (1.333), this requires the video to be rescaled in order to 
give proper aspect at this resolution. Additionally to this fact the sample 
file he tries to play has a bad resolution aswell, as it carries the original 
anamorphic NTSC dvd resolution, which should be rescaled, when ripping to avi 
to either:
- 720x400 when leaving the black bars above and below (16:9 / 1.777 aspect)
- 640x480 (720x540) when dvd has 4:3 (1.333) aspect
- 720x304 when cropping a 2.35:1 movie
- 720x384 when cropping a 1.85:1 movie
- 720x320 when cropping a 2.21:1 movie (rare aspect)

So assuming the movie comes from 16:9 dvd and is uncropped/unrescaled, he 
should play it using mplayer -aspect 16:9 movie.avi

I agree here that SDLs inbuild swscaler is very ugly and that the swscaler 
should be used instead, but last time I checked it couldn't be controlled 
nicely from a vo without integrating it right into the vos code, which is 
ugly, so this feature will probably not occur before mplayer G2 which ha a 
nice interface to controll swscaler from vo.

> Diego
>

-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________