[MPlayer-dev-eng] Re: [NEW PATCH] ftp support

[Alban Bedel]

Hi D Richard Felker III,

on Wed, 13 Aug 2003 12:00:46 -0400 you wrote:

New version of the patch. Should be better now :)

> On Wed, Aug 13, 2003 at 03:30:10PM +0200, Alban Bedel wrote:
> > > * remove net_* and use our conventions for win32 vs unix support
> > What do you mean ? Afaik we only settled to uss recv wich is avaible
> > everywhere. And here it use a define. Imho it's ok. No need to mess
> > with that.
> 
> recv is available everywhere. read is the one that's not...
Now it use recv only.

> > > * probably you could use the existings network.c network
> > > reading/writing api
> > I tried but i dunno if it's really worth it. This is alredy coded to
> > be portable on windows. So just changing the defines to use ours
> > should be enouth. The only advantage (i can see) with using our
> > connect2server is for IPv6 support. But supporting IPv6 mean also some
> > change for the passive mode (and passive is the default). So imho it's
> > not worth it.
> 
> It's also cleaner, and makes it possible for someone to fix ipv6 in
> the future. Or, you could turn passive off by default if ipv6 is
> enabled. No one with ipv6 should need that passive nonsense anyway
> since ipv6 isn't normally nat'd.
You'r right. It now use our connect2server function for the "command"
connection. For the "data" connection there is nothing we have that
can be really useful. So atm it's ipv4 only (see FtpOpenPort()). I'd
like to first be sure that's everything is working ok (for everybody)
on ipv4 before starting to think about ipv6.

I really like to hear from the win32 ppl, pls test !!!
	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ftp.2.diff
Type: application/octet-stream
Size: 38159 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030813/9720064d/attachment.obj>