[MPlayer-dev-eng] Re: [PATCH] ftp support

D Richard Felker III dalias at aerifal.cx
Wed Aug 13 18:00:46 CEST 2003

On Wed, Aug 13, 2003 at 03:30:10PM +0200, Alban Bedel wrote:
> > * remove net_* and use our conventions for win32 vs unix support
> What do you mean ? Afaik we only settled to uss recv wich is avaible
> everywhere. And here it use a define. Imho it's ok. No need to mess
> with that.

recv is available everywhere. read is the one that's not...

> > * probably you could use the existings network.c network reading/writing
> > api
> I tried but i dunno if it's really worth it. This is alredy coded to be
> portable on windows. So just changing the defines to use ours should be
> enouth. The only advantage (i can see) with using our connect2server
> is for IPv6 support. But supporting IPv6 mean also some change for
> the passive mode (and passive is the default). So imho it's not worth
> it.

It's also cleaner, and makes it possible for someone to fix ipv6 in
the future. Or, you could turn passive off by default if ipv6 is
enabled. No one with ipv6 should need that passive nonsense anyway
since ipv6 isn't normally nat'd.


More information about the MPlayer-dev-eng mailing list