[MPlayer-dev-eng] [PATCH] fbdev changes

[D Richard Felker III]

On Wed, Jul 30, 2003 at 02:41:53PM -0500, Joey Parrish wrote:
> On Mon, Jul 14, 2003 at 04:02:04PM -0500, Joey Parrish wrote:
> > Hello,
> > 
> > Attached below is a patch for vo_fbdev.
> > Is this okay to commit?
> 
> Attached yet again, and if there are no objections in a week,
> I'll commit it myself.

Please commit. Even if there are problems, it's 1000x less broken than
the old code, and once you commit, users will find any problems that
might be there. BTW, could you also add support for direct rendering,
i.e. get_image? In the old system, fbdev faked that it supported yuv
colorspaces, then converted yuv2rgb directly into the framebuffer, so
it was fairly fast. But now fbdev is very very slow, since it does:

1) codec gets yuv buffers, sends them to vf_scale
2) vf_scale gets rgb buffer, performs conversion into this buffer
3) vo_fbdev gets rgb buffer from vf_scale, copies it to screen

Slices are helping it a little, but having vf_scale draw directly into
video memory would help a lot!

Rich