[MPlayer-dev-eng] [PATCH] configurable BINDIR and MANDIR; silencing compiler warnings, continued

[Dominik Mierzejewski]

On Sunday, 01 September 2002, Arpi wrote:
> Hi,
[...] 
> > --- MPlayer-20020901/libmpdemux/open.c.warn     Sat Aug 10 18:57:12 2002 
> > +++ MPlayer-20020901/libmpdemux/open.c  Sun Sep  1 16:03:37 2002 
> > @@ -491,7 +491,7 @@
> >  int dvd_parse_chapter_range(struct config *conf, const char *range){
> >    char *s, *t;
>      ^^^^^^^^
> >    conf; /* prevent warning from GCC */
> > -  s = range; 
> > +  strcpy(s,range); 
>      ^^^^^^^^
> ehh, straight wa to sig11...

I knew you'd say that.

[...] 
> maybe s=strdup(range) could work, but imho the current thing is just ok.
> especialy that it's external code, not maintanied by us.

If you say so. But I was thinking about strncpy, or strndup - I wonder what
maximum length should we expect.

[...]
> then let me guess: gcc bug :)

Probably.
 
-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"