[MPlayer-dev-eng] [PATCH] configurable BINDIR and MANDIR; silencing compiler warnings, continued

[Arpi]

Hi,

> I'm sure about off_t* -> off_t, because it's an integer type, not pointer
> type. And I'm fairly sure about the function definition, too.
yes , ok

> > or remove 'const' ?
> 
> I don't like the idea of modifying the function parameters unless it's
> necessary (that's why it's good practice to make them const, isn't it?).
> Here, it isn't required, so I suggest something like:
> 
> --- MPlayer-20020901/libmpdemux/open.c.warn     Sat Aug 10 18:57:12 2002 
> +++ MPlayer-20020901/libmpdemux/open.c  Sun Sep  1 16:03:37 2002 
> @@ -491,7 +491,7 @@
>  int dvd_parse_chapter_range(struct config *conf, const char *range){
>    char *s, *t;
     ^^^^^^^^
>    conf; /* prevent warning from GCC */
> -  s = range; 
> +  strcpy(s,range); 
     ^^^^^^^^
ehh, straight wa to sig11...

my C teacher at the school wrote similar thing to the bboard, and then
everyone (but me) wondered why does it crash the good old DOS borland C :)

maybe s=strdup(range) could work, but imho the current thing is just ok.
especialy that it's external code, not maintanied by us.

> > but is the needed .h file (containing XvShmCreateImage() decl) included
> > there?
> 
> Yup. Line 77 of vo_xv.c:
> #include <X11/extensions/Xvlib.h> 
> 
> Defined there are both XvImage and XvShmCreateImage().

then let me guess: gcc bug :)

> > > loader/win32.c:
> > 
> > leave the loader stuff now, mayeb mail them to Kabi, if he agree i'll
> > commit
> 
> OK, will do.
> 
> PS. I've just did cvs update and guess what, there are more warnings
> waiting to be fixed. :-)

:)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu