[MPlayer-dev-eng] [PATCH] yet another batch of compiler warning fixes

[Dominik Mierzejewski]

On Monday, 25 November 2002, Arpi wrote:
> Hi,
> 
> > > PS. Do you think I could start applying such patches myself directly
> > > into CVS? After posting them here for review, of course. 
> > IMHO yes, but arpi is the one who must decide that
> 
> it's ok.

Thanks.

> but please stop sending (and applying) those 'unused variables' patches.
> they are there mostly for some uncommented/disabled debug code, and if
> you remove them it makes debugging a lot harder.

OK. Will do.

> rather find the right gcc option to hide this kind of warning if you dislike
> it.

I'm on it.

> it's ok to fix other kind of warnings, especially 10l ones (missing return
> value, etc).
> 
> and i really don't like the default -Wall everywhere.
> it's a nightmare to develop code when gcc bombs pages of useless warnings
> and it takes minutes to find the real error or important warning messages
> there.
> 
> if you want to hunt warnings, let's add -Wall, make a patch, but don't force
> everyone to read those warnings!

Very well. Understood.
 
-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"