[MPlayer-dev-eng] typo in tvi_v4l.c ?

Jindrich Makovicka makovick at kmlinux.fjfi.cvut.cz
Wed May 22 14:55:33 CEST 2002


Hello,

trying to do a little code cleanup to get rid of the numerous compiler 
warnings, I came to this piece of code. I think it's a typo but I am not 
familiar with mplayer code so much.

--- orig/MPlayer-0.90pre4/libmpdemux/tvi_v4l.c  Thu May  2 19:12:44 
2002                                     
+++ MPlayer-0.90pre4/libmpdemux/tvi_v4l.c       Wed May 22 10:41:26 
2002                                     
@@ -709,7 +709,7 
@@                                                                                           

                                                                                                              

            priv->tuner.mode = 
req_mode;                                                                      

                                                                                                              

-           if (control(priv->video_fd, TVI_CONTROL_TUN_SET_TUNER, 
&priv->tuner) != TVI_CONTROL_TRUE)        
+           if (control(priv, TVI_CONTROL_TUN_SET_TUNER, &priv->tuner) 
!= TVI_CONTROL_TRUE)                  
                
return(TVI_CONTROL_FALSE);                                                                    

            
return(TVI_CONTROL_TRUE);                                                                         

        
}                                                                                                     


All my changes are in the attachment. I just tried to add the missing 
prototypes and explicit typecasting. Also some prototypes were unified 
(eg. the color conversion functions with int <-> unsigned int mismatches).

Regards,

-- 
Jindrich Makovicka

-------------- next part --------------
A non-text attachment was scrubbed...
Name: squish_warnings.diff.gz
Type: application/gzip
Size: 10730 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20020522/7647f2ad/attachment.bin>


More information about the MPlayer-dev-eng mailing list