[MPlayer-dev-eng] [PATCH] Fix for xv black bars, 2 other xv fixes

[Tom Lees]

On Sun, 2002-05-05 at 16:36, Arpi wrote:
> 
> with matrox g400, i can decerase window size and still get scaling
> anywya i know that 3dfx xv cannot downscale (while the card can do that,
> with our native driver). is tehre any way to query if the Xv driver can
> downscale or upscale-only? if it's upsacel only, then sw scaler can be used
> for downscaling, the current vfilter arch supports this...

In which case we should fix x11_common.c so that resize is allowed after
fs switch (see attached patch).

> 
> > ld_height;
> > -    vo_x11_decoration( mDisplay,vo_window,1 );
> >     }
> >   vo_x11_sizehint( vo_dx,vo_dy,vo_dwidth,vo_dheight,0 );
> >   XMoveResizeWindow( mDisplay,vo_window,vo_dx,vo_dy,vo_dwidth,vo_dheight );
> > + vo_x11_decoration( mDisplay,vo_window,(vo_fs) ? 0 : 1 );
> 
> is it always OK to move vo_x11_decoration() after window resize?
> i mean, window with decoration maybe cannot be resized to full size?

Ah... yes, this breaks under icewm. For some reason when using fsmode 1,
under sawfish switching to fullscreen would not alter the position of
the window only the size. I found an XSync does the trick as well.

I also noticed a potential bug in the Motif decorations hinting not
setting the functions to 0 on fullscreen which is fixed in the patch.

I only have one remaining problem with the fullscreen code now: under
icewm an initial fullscreen will not cover "on top" windows (like the
GNOME bar) but will cover it if you switch out of then into fs mode. I
haven't yet tracked it down though. 

The attached patch is against CVS updated after previous fix applied.

Tom Lees

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mp_xv_fix2.diff
Type: text/x-patch
Size: 2570 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20020505/8c6119b6/attachment.bin>