[MPlayer-dev-eng] [PATCH] Fix for xv black bars, 2 other xv fixes

[Arpi]

Hi,

> Since the xv code was cleaned up to remove the drwcX etc which wasn't
> used except for debug, one vital line was removed (setting drwX and drwY
> to 0) which introduced the "black bars" in xv bug. I think it was only
> triggered in certain window managers. I use sawfish, it was definitely
> seen with that.
> 
> Other small fix #1 re-adds the fsmode 1 and fsmode 8 options and fixes
> fsmode 1 so it is only engaged during fullscreen.

thanks, applied

> Other small fix #2 makes xv's initial window use the "BaseSize"
> attribute so that it cannot be resized lower than the video resolution
> (as xv will not shrink it, only grow so this leads to cropping). This
> attribute is at present set when returning from fullscreen mode but not
> when setting up to start with - this fixes that.

with matrox g400, i can decerase window size and still get scaling
anywya i know that 3dfx xv cannot downscale (while the card can do that,
with our native driver). is tehre any way to query if the Xv driver can
downscale or upscale-only? if it's upsacel only, then sw scaler can be used
for downscaling, the current vfilter arch supports this...

> ld_height;
> -    vo_x11_decoration( mDisplay,vo_window,1 );
>     }
>   vo_x11_sizehint( vo_dx,vo_dy,vo_dwidth,vo_dheight,0 );
>   XMoveResizeWindow( mDisplay,vo_window,vo_dx,vo_dy,vo_dwidth,vo_dheight );
> + vo_x11_decoration( mDisplay,vo_window,(vo_fs) ? 0 : 1 );

is it always OK to move vo_x11_decoration() after window resize?
i mean, window with decoration maybe cannot be resized to full size?


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu