[MPlayer-dev-eng] proposed frame stepping patch

[Arpi]

Hi,

> attached is a patch that adds forward frame stepping using TAB key, when
> mplayer is in pause mode. If frame stepping was used, mplayer will seek
> one second after resuming from pause to resync audio, this will of
> course only work correctly if stream is seekable.
> 
> Is it OK, to apply this to cvs?

no...

the video decoding+flipping code should NOT be duplicated...
anyway your pacth will break play from stdin, the original if didn't call
mplayer_get_key if use_stdin!=0

the right way to do this: exit pause mode if user press ket TAB (i prefer
left/right arrows but it doesn't matter) but set a flag so after decoding
and displaying that frame it will enter pause mode again.
also patch the audio code to skip audio playback if this flag is set.

for fileformats with interleaved audio+video it will crash after a few
frames skipped, due to buffer overflow. so it's better to patch audio
decoding code to in frameskip mode read max N bytes where N is calculated
from previous video frame duration and audio samplerate/size.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu