[MPlayer-dev-eng] [PATCH] xv-options (brightness etc)

[Felix Buenemann]

On Friday, 18. January 2002 00:25, Pásztor Szilárd wrote:
> Hi,
>
> until libvo2 is done... :)
>
>   Here is a patch against the current CVS version (as of 17. jan. 23:53),
> adding support to vo_xv for adjusting brightness/contrast/hue/saturation.
> Since it's done by the XV extension its codec-independent, and imo very
> useful with ffmpeg codecs or any other than original divx3/divx4.
>
>   The patch fits into mplayer's current architecture. XV is not used where
> the codec supports these settings but if it doesnt, adjusting talks to XV
> and it looks exactly the same via osd. The only difference is that the osd
> layer output is also affected (clock etc) but it's inevitable with XV.
>
> To enable this thing, I had to make a new entry into LIBVO_EXTERN called
> set_colors and put it into every other vo_*.c too, as an empty function.
> The main thing is done in vo_xv.c, and mplayer.c had to be changed to call
> the set_colors() function if set_video_colors returns with 0 (that is,
> codec has no support). Upon XV init, the xserver is queried about the
> attributes and the ranges and these attributes are handled accordingly
> later on. If these attributes (or some of them) are unavailable,
> set_colors() also returns 0 and has no effect. I hope it makes the patch
> usable for any video card.
>
Please do the patch again so it only modifies vo_xv, brightness etc. control 
may always be done using xv, no matter what codec is used and if that codec 
itself suports it (it doesn't matter if I do it via codec or xv even if osd 
changes).
>
> surmoka
>
-- 
Best Regards,
	Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________