[MPlayer-dev-eng] bug in playtree code

[Felix Buenemann]

Hi,

there's a bug in playtree.c code, that causes it to sig11 at eg. EOF of a 
SVCD if the iter struct is undefined.
The problematic code starts at playtree.c line 406, I think it's best to let 
the author fix it instead me hacking something like if(iter) around the whole 
function-body.

Btw. playtree code shoild maybe set current_module to playtree...

For reference, here's the debug session:
(the -ss seeks to shortly before movie ending)

Starting program: /home/atmosfear/develop/mplayer/main/./mplayer -vcd 1 -ss 
00:35:35
[New Thread 1024 (LWP 3900)]


MPlayer CVS-020113-00:18-2.95.3 (C) 2000-2002 Arpad Gereoffy (see DOCS!)

CPU vendor name: GenuineIntel  max cpuid level: 2
CPU: Intel Celeron 2/Pentium III Coppermine,Geyserville (Type: 6, Stepping: 6)
Testing OS support for SSE... yes.
Testing OS support for SSE unmasked exceptions... yes.
Tests of OS support for SSE passed.
CPUflags: Type: 6 MMX: 1 MMX2: 1 3DNow: 0 3DNow2: 0 SSE: 1 SSE2: 0
Compiled for x86 CPU with features: MMX MMX2 SSE
Reading /home/atmosfear/.mplayer/codecs.conf: 28 audio & 73 video codecs
Font /home/atmosfear/.mplayer/font/font.desc loaded successfully! (206 chars)
Setting up lirc support...
mplayer_lirc: could not connect to socket
mplayer_lirc: Permission denied
Failed opening lirc support!
You won't be able to use your remote control
Linux RTC init: open: Permission denied
Using usleep() timing
track 01:  adr=1  ctrl=6  format=2  00:02:00  mode: 0
track 02:  adr=1  ctrl=6  format=2  00:08:00  mode: 0
header block 1 size: 0
Detected MPEG-PS file format!
VIDEO:  MPEG2  480x480  (aspect 2)  29.97 fps  3062.5 kbps (382.8 kbyte/s)
[V] filefmt:2  fourcc:0x10000002  size:480x480  fps:29.97  ftime:=0.0334
Detected audio codec: [mp3] drv:1 (MPEG layer-2, layer-3)
mp3lib: Processor ID: 686
mp3lib: Using Pentium-MMX optimized decore.
AUDIO: srate=44100  chans=2  bps=2  sfmt=0x10  ratio: 28000->176400
Detected video codec: [mpeg12] drv:1 prio:0 (MPEG 1 or 2)
mpeg2dec-0.2.0-release (C) 2000-2001 Aaron Holtzman & Michel Lespinasse
libmpeg2: Using MMXEXT for IDCT transform
libmpeg2: Using MMXEXT for motion compensation
Movie-Aspect is 1.33:1 - prescaling to correct movie aspect.
VO: [sdl] 480x480 => 640x480 Planar YV12
SDL: Using driver: x11
AO: [oss] 44100Hz Stereo Signed 16-bit (Little-Endian)
ao2: 44100 Hz  2 chans  Signed 16-bit (Little-Endian)
audio_setup: sample format: Signed 16-bit (Little-Endian) (requested: Signed 
16-bit (Little-Endian))
audio_setup: using 2 channels (requested: 2)
audio_setup: using 44100 Hz samplerate (requested: 44100)
audio_setup: frags:  64/64  (1024 bytes/frag)  free:  65536
Start playing...
A:2877.6 V:2877.6 A-V: -0.002 ct:  0.090   84/ 67   5%  8%  5.1% 0 0 0%
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1024 (LWP 3900)]
play_tree_iter_step (iter=0x0, d=1, with_nodes=0) at playtree.c:406
406       if(iter->tree == NULL) {
(gdb) bt
#0  play_tree_iter_step (iter=0x0, d=1, with_nodes=0) at playtree.c:406
#1  0x08052deb in main (argc=5, argv=0xbffff504, envp=0xbffff51c) at 
mplayer.c:2348
#2  0x404fc7ee in __libc_start_main () from /lib/libc.so.6
(gdb) c
Continuing.

MPlayer interrupted by signal 11 in module: unknown
*** free_stream() called ***

Program exited with code 01.
(gdb)

-- 
Best Regards,
	Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________