[MPlayer-dev-eng] Patch: Display OSD in the black stripes area with vo SDL

Alban Bedel albeu at free.fr
Mon Feb 11 15:05:02 CET 2002


Hi Fredrik Kuivinen,

on Sun, 10 Feb 2002 16:12:14 +0100 you wrote:

> On Sun, Feb 10, 2002 at 03:47:48PM +0100, Alex Beregszaszi wrote:
> > Hi,
> > 
> > Could you make two seperate patches, one for OSD and one for SDL?
> >
> 
> Hm yes I could do that. But the sdl patch will depend on the osd patch. 
> 
> > I think the OSD part will be registered as cosmetic changes.
> > 
> 
> And the rule "No cosmetic changes are allowed in cvs" will apply? If that is
> the case I don't think it is a cosmetic change. It is pretty useless to render
> the OSD in every frame if it isn't needed. And I don't see anyway to detect
> when the OSD changed without this patch.
	For osd_func use a last value. After each rendering save the osd_func
	value and on the next frame compare it to the current value to see if there
	were any change.
	Beside this imho this stuff must be done in a generic way, not per driver,
	but I'm not the good one to debate on this point ;) .
		Albeu



More information about the MPlayer-dev-eng mailing list