[MPlayer-dev-eng] [PATCH] vo_*->control

Arpi arpi at thot.banki.hu
Fri Feb 8 01:01:26 CET 2002


Hi,

> > sorry for being rude, i understand that you worked a lot on this patch, but
> > it's messy, and you had to work less if you do teh above way (just copypaste
> > the above code to each vo driver right after the query_format function)
> 
> Uhm. Just to be sure, you are going to throw this patch in the trashcan?

sorry, i don't like that multipage indent changes you did...
(moving right the big query_format stuff to fit your indenting in new
control())

it's CVS policy... nothing new or nothing against you.

this patch should be remade keeping the rules and making minimal changes.
as you cannot test this code, neither me or others here, it must be bugfree
for first time. and to make it verifiable and clean, don't change any line.


A'rpi / Astral & ESP-team

--
"I don't RTFM? Wow. What's the meaning of this? It's new for me."
	-- Martin Baum, a tipical MPlayer user...



More information about the MPlayer-dev-eng mailing list