[MPlayer-dev-eng] [PATCH] vo_*->control

[Arpi]

Hi,

> Here it is. The patch that adds a control interface to every vo_* device
> and removes vo_*->query_format and ->query_vaa.
> It compiles on my machine but it is still likely there are bugs in some
> of the modules which are automatically disabled here. The patch is too
> big to be bug free out of the box, trial and error ppl.
> It seemingly works perfectly with vo_xv and vo_dxr3, if it doesn't work
> with vo_XX please fix this instead of telling me that it does not work.
> It was pain enough to implement this into every device...
> 
> //David

Hmm. Intead of messing/fscking up indenting and moving code from this place
to another, why don't you just called it?

control(int cmd,void* arg,...){
switch(cmd){
case QUERY_FORMAT:
	return query_format(*(int*)arg);
}
return VO_NOTIMPL;
}

would be much cleaner...
anyway, you always added break; after return. it's 100% nonsense.

sorry for being rude, i understand that you worked a lot on this patch, but
it's messy, and you had to work less if you do teh above way (just copypaste
the above code to each vo driver right after the query_format function)


A'rpi / Astral & ESP-team

--
"I don't RTFM? Wow. What's the meaning of this? It's new for me."
	-- Martin Baum, a tipical MPlayer user...