[MPlayer-dev-eng] [PATCH] vo_*->control

David Holm david at realityrift.com
Thu Feb 7 23:31:06 CET 2002


> Hmm. Intead of messing/fscking up indenting and moving code from this place
> to another, why don't you just called it?

I don't like enlargening the codebase. Nice clean and simple is more my
way of doing things.
 
> would be much cleaner...
> anyway, you always added break; after return. it's 100% nonsense.

I know, this is an old habit of mine =(
 
> sorry for being rude, i understand that you worked a lot on this patch, but
> it's messy, and you had to work less if you do teh above way (just copypaste
> the above code to each vo driver right after the query_format function)

Well, I'm a perfectionist, and I strive to make everything I code as
neat and clean as possible. A function call adds a call, and I come
frome the old school where they tought us that jumps and branches ate
cpu cycles (I know they don't any more, but old habits die hard).

//David




More information about the MPlayer-dev-eng mailing list