[MPlayer-dev-eng] [PATCH] [REPOST] some minor errors and compiler warnings fixes

Dominik Mierzejewski dominik at rangers.eu.org
Wed Aug 28 11:05:12 CEST 2002


On Wednesday, 28 August 2002, Michael Niedermayer wrote:
> Hi
> 
> On Wednesday 28 August 2002 02:09, Dominik Mierzejewski wrote:
> [...]
> > mplayer-warnings.patch:
> > 	fixes missing declarations and #includes, unused variables,
> > 	incompatible types in the rest of the code and also some errors
> ok the libavcodec stuff is applied, except
> -                int dummy= s->hierachy_type= get_bits1(&s->gb);
> +                /*int dummy= s->hierachy_type= get_bits1(&s->gb);
>                  int ref_layer_id= get_bits(&s->gb, 4);
>                  int ref_layer_sampling_dir= get_bits1(&s->gb);
>                  int h_sampling_factor_n= get_bits(&s->gb, 5);
>                  int h_sampling_factor_m= get_bits(&s->gb, 5);
>                  int v_sampling_factor_n= get_bits(&s->gb, 5);
> -                int v_sampling_factor_m= get_bits(&s->gb, 5);
> +                int v_sampling_factor_m= get_bits(&s->gb, 5);*/
> cuz its broken, hint, see get_bits(...) at the right, u cant outcomment them 
> ...

Sorry, my mistake. I just blindly commented out all "warning: unused variable"
stuff. which is obviously not the wisest thing to do.

> btw, please send libavcodec patches to the ffmpeg devel ML in the future

*sigh* OK, I'll try.

-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"



More information about the MPlayer-dev-eng mailing list